Bug #7264
CNCore.hasReservation null Subject parameter
100%
Description
While testing synchronization, noticed that the CNCore.hasReservation method takes 2 parameters (aside from the Session), the pid and the subject, but has no InvalidRequest exception - something that could be returned if either parameter was null, especially the subject, since it is a query-parameter.
The hasReservation implementation in d1_identity_manager looks like it would blow up with an NPE if the subject parameter was null.
I think we need to add InvalidRequest to the method signature (in V2).
(hasReservation is routinely called by synchronization, and if an MN neglects to populate the submitter fields in the systemMetdata it holds, we'd likely be seeing a lot of SyncFaileds due to NPEs)
Subtasks
Related issues
Associated revisions
refs: #7264. Added InvalidRequest to client method implementations of hasReservation.
refs: #7264. Added InvalidRequest to client method implementations of hasReservation.
History
#1 Updated by Rob Nahf over 9 years ago
- Description updated (diff)
#2 Updated by Ben Leinfelder over 9 years ago
- % Done changed from 0 to 30
- Status changed from New to In Progress
The CN controller was checking for cases when the subject parameter was not provided in the request, but I added an extra check in the underlying implementation that also checks for nulls.
#3 Updated by Ben Leinfelder over 9 years ago
- Status changed from In Progress to Testing
- % Done changed from 30 to 50
#4 Updated by Rob Nahf about 9 years ago
- Related to Story #7419: hasReservation should not check if an Identifier is already registered added
#5 Updated by Dave Vieglais over 8 years ago
- Status changed from Testing to Closed
- % Done changed from 50 to 100
