Project

General

Profile

Bug #7264

CNCore.hasReservation null Subject parameter

Added by Rob Nahf over 8 years ago. Updated about 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Architecture Design
Target version:
Start date:
2015-10-17
Due date:
% Done:

100%

Milestone:
None
Product Version:
*
Story Points:
Sprint:

Description

While testing synchronization, noticed that the CNCore.hasReservation method takes 2 parameters (aside from the Session), the pid and the subject, but has no InvalidRequest exception - something that could be returned if either parameter was null, especially the subject, since it is a query-parameter.

The hasReservation implementation in d1_identity_manager looks like it would blow up with an NPE if the subject parameter was null.

I think we need to add InvalidRequest to the method signature (in V2).

(hasReservation is routinely called by synchronization, and if an MN neglects to populate the submitter fields in the systemMetdata it holds, we'd likely be seeing a lot of SyncFaileds due to NPEs)


Subtasks

Task #7443: add InvalidRequest to hasReservation signature in documentationClosedDave Vieglais


Related issues

Related to Infrastructure - Story #7419: hasReservation should not check if an Identifier is already registered Closed 2015-10-08

Associated revisions

Revision 16693
Added by Rob Nahf over 8 years ago

refs: #7264. Added InvalidRequest to client method implementations of hasReservation.

Revision 16693
Added by Rob Nahf over 8 years ago

refs: #7264. Added InvalidRequest to client method implementations of hasReservation.

History

#1 Updated by Rob Nahf over 8 years ago

  • Description updated (diff)

#2 Updated by Ben Leinfelder over 8 years ago

  • % Done changed from 0 to 30
  • Status changed from New to In Progress

The CN controller was checking for cases when the subject parameter was not provided in the request, but I added an extra check in the underlying implementation that also checks for nulls.

#3 Updated by Ben Leinfelder over 8 years ago

  • Status changed from In Progress to Testing
  • % Done changed from 30 to 50

#4 Updated by Rob Nahf over 8 years ago

  • Related to Story #7419: hasReservation should not check if an Identifier is already registered added

#5 Updated by Dave Vieglais about 8 years ago

  • Status changed from Testing to Closed
  • % Done changed from 50 to 100

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 14.8 MB)