Bug #7264
Updated by Rob Nahf almost 9 years ago
While testing synchronization, noticed that the CNCore.hasReservation method takes 2 parameters (aside from the Session), the pid and the subject, but has no InvalidRequest exception - something that could be returned if either parameter was null, especially the subject, since it is a query-parameter.
The hasReservation implementation in d1_identity_manager looks like it would blow up with an NPE if the subject parameter was null.
I think we need to add InvalidRequest to the method signature (in V2).
(hasReservation is routinely called by synchronization, and if an MN neglects to populate the submitter fields in the systemMetdata it holds, we'd likely be seeing a lot of SyncFaileds due to NPEs)
The hasReservation implementation in d1_identity_manager looks like it would blow up with an NPE if the subject parameter was null.
I think we need to add InvalidRequest to the method signature (in V2).
(hasReservation is routinely called by synchronization, and if an MN neglects to populate the submitter fields in the systemMetdata it holds, we'd likely be seeing a lot of SyncFaileds due to NPEs)
