Project

General

Profile

Bug #8160

ReplicationManager doesn't allow replication if a NodeReplicationPolicy exists, but allowedFormats aren't defined

Added by Rob Nahf over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Urgent
Assignee:
Category:
d1_replication
Target version:
Start date:
2017-08-11
Due date:
% Done:

100%

Milestone:
None
Product Version:
*
Story Points:
Sprint:

Description

The issue is that the NodeReplicationPolicy type creates an Empty List for allowedNodes, but the check in ReplicationManager uses a allowedNodes != null check to know whether to limit by formats. (in the method passesReplicationPolicies(...))

The solution is to add an empty list check as well as a null check. Probably should add other empty checks for other fields, too.

This is urgent for Arctic MN and NCEI for an NSF review on August 21st.

Associated revisions

Revision 18923
Added by Rob Nahf over 6 years ago

fixes #8160 in 2.3 branch: In ReplicationManager, now checking for empty lists as well as nulls for allowedFormats, allowedNodes, and blockedMemberNodes properties.

Revision 18923
Added by Rob Nahf over 6 years ago

fixes #8160 in 2.3 branch: In ReplicationManager, now checking for empty lists as well as nulls for allowedFormats, allowedNodes, and blockedMemberNodes properties.

History

#1 Updated by Rob Nahf over 6 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

Applied in changeset d1|r18923.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 14.8 MB)