Bug #7642
D1Client.getCN(Session s) method doesn't use the session
100%
Description
this method was introduced in v1 very early, and doesn't look like it's being used.
(Not by metacat, d1_portal, cn_common, d1_replication, d1_synchronization, d1_identity_manager, d1_cn_nodeRegistry, d1_cn_rest)
The methods should be either (a) deprecated, leaving D1Client to continue to only support use of the default session (and have alternate sessions passed in through the method calls), or if really necessary (b) fully supported through the management of a session-MultipartRestClient map.
Recommend the former, since the method is not in use, and the latter choice adds a lot of complication to the code.
(solution should apply to both v1 and v2 D1Client classes)
Related issues
Associated revisions
fixes #7642: deprecated the D1Client.getCN(Session s) methods.
fixes #7642: deprecated the D1Client.getCN(Session s) methods.
History
#1 Updated by Rob Nahf almost 9 years ago
- Related to Feature #5142: Make it possible for users to change to another cn in the D1Client class in d1_libclient_java module added
#2 Updated by Rob Nahf almost 9 years ago
- Related to Task #2750: add D1Client.getCN(Session session) method added
#3 Updated by Rob Nahf almost 9 years ago
I searched the dataone github repositories for use of getCN methods, and couldn't find any of the one that takes the session parameter.
(https://github.com/DataONEorg).
#4 Updated by Rob Nahf almost 9 years ago
- % Done changed from 0 to 30
- Status changed from New to In Progress
#5 Updated by Rob Nahf almost 9 years ago
- Status changed from In Progress to Closed
- % Done changed from 30 to 100
