Project

General

Profile

Bug #7546

ObjectFormatCache can't be instantiated if local file is not findable

Added by Rob Nahf about 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
d1_libclient_java
Target version:
Start date:
2015-12-11
Due date:
% Done:

100%

Milestone:
None
Product Version:
*
Story Points:
Sprint:

Description

ObjectFormatCache extends ObjectFormatServiceImpl in d1_common_java, and both are singletons. For situations where the fallback local FormatList can't be opened, a ServiceFailure is thrown before ObjectFormatCache is able to try refreshing from CN.listFormats.

The use of inheritance here prevents use from catching the ServiceFailure thrown from the ObjectFormatServiceImpl constructor.

exception generation should probably be refactored out of the constructors and into the getInstance() methods for both classes, or inheritance abandoned.

Associated revisions

Revision 17531
Added by Rob Nahf almost 6 years ago

fixes #7546, refs #7635, #7536. Refactored ObjectFormatCache to be thread safe, and not dependent on the shipped ObjectFormatList file. Refactored getInstance methods of CertificateManager and ObjectFormatCache for thread safety. Removed unnecessary dependency on a live CN in d1client.properties.

Revision 17531
Added by Rob Nahf almost 6 years ago

fixes #7546, refs #7635, #7536. Refactored ObjectFormatCache to be thread safe, and not dependent on the shipped ObjectFormatList file. Refactored getInstance methods of CertificateManager and ObjectFormatCache for thread safety. Removed unnecessary dependency on a live CN in d1client.properties.

History

#1 Updated by Rob Nahf almost 6 years ago

  • Target version changed from Release Backlog to CCI-2.1.0

#2 Updated by Rob Nahf almost 6 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

refactored inheritance out of the design. ObjectFormatCache calls ObjectFormatServiceImpl if needed.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 14.8 MB)