Project

General

Profile

Story #6377

Review CNode initialization in ReplicationManager - it doesn't use local CN reference

Added by Rob Nahf about 7 years ago. Updated almost 4 years ago.

Status:
In Progress
Priority:
Normal
Assignee:
Category:
d1_replication
Target version:
Start date:
2014-09-25
Due date:
2014-09-25
% Done:

30%

Story Points:
Sprint:

Description

There is complicated fallback logic for performing certain CN API calls where the ReplicationManager CNode is supposed to be the local CN baseurl, and if that fails, it falls back to using the ReplicationService (roundRobin) CN to perform the same call. However, ReplicationManager is already using the RR CN, unless the D1Client.CN_URL is different for different deployments. But in that case, ReplicationService would also use the same D1Client.CN_URL property.

Simplifying this would help encapsulate client interaction, and connection management. Fallback CNode procurement uses D1NodeFactory + a locally instantiated DefaultHttpMultipartRestClient for both ReplicationManager and ReplicationServices (a recent temporary solution for v2). This leads to two ConnectionManagers in the underlying HttpClient.

Since ReplicationManager is a complicated class, I would first look to encapsulate logic in the ReplicationService class.


Related issues

Related to Infrastructure - Story #8639: Replication performance is too slow to service demand New 2018-07-04

History

#1 Updated by Dave Vieglais about 7 years ago

  • Due date set to 2014-09-25
  • Start date set to 2014-09-25
  • Target version set to Release Backlog

#2 Updated by Rob Nahf almost 6 years ago

  • Assignee changed from Robert Waltz to Rob Nahf
  • Target version changed from Release Backlog to CCI-2.2.0

work on this while working on the other Replication sotries for v2.2. Some of the D1Client behavior has since been cleaned up, so reconfirm the situation is still the same.

#3 Updated by Dave Vieglais over 5 years ago

  • Target version changed from CCI-2.2.0 to CCI-2.3.0

#4 Updated by Rob Nahf over 5 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 30

#5 Updated by Dave Vieglais almost 5 years ago

  • Target version changed from CCI-2.3.0 to CCI-2.3.2

#6 Updated by Dave Vieglais almost 5 years ago

  • Target version changed from CCI-2.3.2 to CCI-2.4.0

#7 Updated by Dave Vieglais almost 4 years ago

  • Sprint set to CCI-2.3.8

#8 Updated by Dave Vieglais over 3 years ago

  • Related to Story #8639: Replication performance is too slow to service demand added

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 14.8 MB)