Project

General

Profile

Task #2476

Metacat should handle "empty" failure strings correctly for CNReplication.setReplicationStatus()

Added by Chris Jones almost 9 years ago. Updated almost 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Metacat
Start date:
2012-03-13
Due date:
% Done:

100%

Milestone:
CCI-1.0.0
Product Version:
*
Story Points:
Sprint:

Description

When sending failure="" in an MMP attachment for any replication status other than FAILED, D1ResourceHandler.collectReplicationStatus() should interprety the empty parameter as null and not attempt to traverse the XML snippet.

org.dataone.service.exceptions.ServiceFailure: Couldn't traverse the replication failure exception: Premature end of file.
at edu.ucsb.nceas.metacat.restservice.D1ResourceHandler.collectReplicationStatus(D1ResourceHandler.java:249)
at edu.ucsb.nceas.metacat.restservice.CNResourceHandler.setReplicationStatus(CNResourceHandler.java:1331)
at edu.ucsb.nceas.metacat.restservice.CNResourceHandler.handle(CNResourceHandler.java:326)

History

#1 Updated by Chris Jones almost 9 years ago

  • Subject changed from Metacat should handle "empty" failure stings correctly for CNreplication.setReplicationStatus() to Metacat should handle "empty" failure stings correctly for CNReplication.setReplicationStatus()

#2 Updated by Chris Jones almost 9 years ago

also, when an exception document is included but status != FAILED:

CN Dispatching: /d1/cn/replicaNotifications/AbuseStatement:V736ac04f-08ba-49ac-a7ad-67a2881c1714
20120313-19:06:00: [INFO]: CN Dispatching proxy... [org.dataone.cn.rest.proxy.service.impl.AbstractProxyServiceImpl]
HTTP Verb: PUT
org.dataone.service.exceptions.ServiceFailure
at edu.ucsb.nceas.metacat.restservice.CNResourceHandler.handle(CNResourceHandler.java:398)
at edu.ucsb.nceas.metacat.restservice.D1RestServlet.doPut(D1RestServlet.java:102)

#3 Updated by Chris Jones almost 9 years ago

  • Subject changed from Metacat should handle "empty" failure stings correctly for CNReplication.setReplicationStatus() to Metacat should handle "empty" failure strings correctly for CNReplication.setReplicationStatus()

Lastly, not sending a cert with the call causes the ServiceFailure. check D1ResourceHandler to see if this really should be returning InvalidToken or InvalidRequest.

#4 Updated by Ben Leinfelder almost 9 years ago

Now checking if the failure file in the MMP is empty (as well as just null). Hopefully this handles the first case

#5 Updated by Ben Leinfelder almost 9 years ago

Metacat trunk should now handle these cases -- need to test again

#6 Updated by Chris Jones almost 9 years ago

  • Status changed from New to Closed

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 14.8 MB)