Project

General

Profile

Task #1642

Story #1639: use CNCore/CNode for all ObjectFormat methods

use ObjectFormatCache when implementing CNode methods

Added by Ben Leinfelder over 13 years ago. Updated over 13 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
2011-06-09
Due date:
% Done:

0%

Milestone:
Product Version:
*
Story Points:
Sprint:

Description

Since ObjectFormatCache already implements the CNCore methods, we can just delegate to that class from CNode (the libclient implementation of CNCore).

Optionally merge ObjectFormatCache with ObjectFormatServiceImpl if they can logically/feasibly be combined into a single class.

History

#1 Updated by Chris Jones over 13 years ago

  • Status changed from New to Rejected

CNode already implements listFormats() and getFormat() by calling the D1RestClient, and the ObjectFormatCache uses this implementation to cache the list. So, I think the functionality is already there, but is the reverse of what is suggested here. Also, ObjectFormatCache and ObjectFormatServiceImpl can't be merged because there would be a d1_common_java dependency on d1_libclient_java in the tests. We've discussed this and decided to keep them separate. I'll reject this for now unless CNode should depend on ObjectFormatCache instead of the other way around.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 14.8 MB)