Task #8110
Bug #8106: Difficulty Distinguishing Between Different Kinds of Failed Sync "Not Found" Error Messages
metacat.EventLog.getReport should downgrade a log.WARN to log.DEBUG
100%
Description
From the first example in #8106, a McdbDocNotFoundException thrown by DocumentUtil.appendRev is being caught in a generic catch (Exception e) block in EventLog.getReport (line 289) and logged as a WARN. This was triggered from a simple getSystemMetadata request, and appears to happen whenever getSystemMetadata is given an unknown identifier. Since this is a normal and trivial occurrence, the McdbDocNotFoundException should be caught separately and logged only at a log DEBUG level (without the stacktrace, either).
[METACAT] [WARN] [2017-06-17 18:37:15] : Could not check docid for revision: doi:10.6067:XCV8WM1D1X_meta$v=1356819351482 [edu.ucsb.nceas.metacat.EventLog] edu.ucsb.nceas.metacat.McdbDocNotFoundException: the requested docid 'doi:10.6067:XCV8WM1D1X_meta$v=1356819351482' does not exist at edu.ucsb.nceas.metacat.util.DocumentUtil.appendRev(DocumentUtil.java:328) at edu.ucsb.nceas.metacat.EventLog.getReport(EventLog.java:288) at edu.ucsb.nceas.metacat.EventLog.isDeleted(EventLog.java:395) at edu.ucsb.nceas.metacat.dataone.D1NodeService.userHasPermission(D1NodeService.java:1211) at edu.ucsb.nceas.metacat.dataone.D1NodeService.isAuthorized(D1NodeService.java:1153) at edu.ucsb.nceas.metacat.dataone.D1NodeService.getSystemMetadata(D1NodeService.java:782) at edu.ucsb.nceas.metacat.restservice.v2.CNResourceHandler.getSystemMetadataObject(CNResourceHandler.java:644) at edu.ucsb.nceas.metacat.restservice.v2.CNResourceHandler.handle(CNResourceHandler.java:188) at edu.ucsb.nceas.metacat.restservice.D1RestServlet.doGet(D1RestServlet.java:76) at javax.servlet.http.HttpServlet.service(HttpServlet.java:620) at javax.servlet.http.HttpServlet.service(HttpServlet.java:727) at
History
#1 Updated by Dave Vieglais over 7 years ago
- Target version set to CCI-2.3.6
#2 Updated by Jing Tao about 7 years ago
- Target version changed from CCI-2.3.6 to CCI-2.3.7
#3 Updated by Jing Tao about 7 years ago
- Status changed from New to Closed
- % Done changed from 0 to 100
The changed was committed to both trunk and 2.8 branch.
#4 Updated by Dave Vieglais almost 7 years ago
- Sprint set to CCI-2.3.7