Project

General

Profile

Bug #7624

Series head resolution should use obsoletes field as part of determination

Added by Rob Nahf over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Metacat
Target version:
Start date:
2016-01-28
Due date:
% Done:

100%

Milestone:
None
Product Version:
*
Story Points:
Sprint:

Description

Reviewing the cases for resolving a SID to the latest PID, I came across a missing case that I believe will return the wrong PID for the situation.

It pertains to mainly mutable Member Nodes where obsoletedBy fields likely never get populated, increasing the reliance on dateUploaded to determine the head. The general logic for resolving SIDs is to prefer obsolete chains over upload date, since the former is a direct reflection of what the submitter intends, whereas upload date is an accident of the order in which objects are successfully created on the MN. (For example, a systemMetadata problem with an earlier revision could result in a later upload date than a later revision.

The scenario is best expressed as the following:

P1(S,D2) <- P2(S,D1)

where S is the SeriesId, and D1 and D2 are upload dates, and where D2 is later than D1.

S should resolve to P2, but by current algorithm in Metacat's IdentifierManager.getHeadPid(Identifier sid), two type 1 ends are produced, and their upload dates decide the head, so P1 is determined to be the head.

The obsoletes field in P2 in this case is ignored information that should not be. The obsoletes field is used elsewhere in the algorithm to resolve situations where there is one missing revision in an otherwise complete chain.

It would be implemented as a secondary step when 2 or more candidate revisions are encountered.

History

#1 Updated by Rob Nahf over 5 years ago

  • Description updated (diff)

#2 Updated by Jing Tao over 5 years ago

  • Assignee set to Jing Tao

#3 Updated by Jing Tao over 5 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

Update both code and documentation.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 14.8 MB)