Story #4654

Independent review of d1_common_java

Added by Dave Vieglais about 10 years ago. Updated over 6 years ago.

Robert Waltz
Target version:
Start date:
Due date:
% Done:


Story Points:


A casual independent review of d1_common_jva has revealed a number of suggested changes. These are included as separate tasks under this story.


Task #4655: Pom appears to bring in plugins as project dependencies (maven-jar-plugin, maven-clean-plugin)New

Task #4656: Pom indentation makes it unnecessarily hard to readClosed

Task #4657: Pom versions are mixed between properties and inline (e.g. <version>1.8.4</version>)NewRob Nahf

Task #4658: Pom has unnecessary and confusing comment: <!-- take out the placeholder -->ClosedRob Nahf

Task #4659: has "import java.sql.Date"ClosedRob Nahf

Task #4660: src/main/java has XML filesNewRobert Waltz

Task #4661: Deprecated methods give no indication of the (Java) version in which they will be removedNew

Task #4662: testMultipartTransmission does not respect Java naming conventionsClosed

Task #4663: src/main/resources appears to have config for log4j through commons-logging but neither logging library is declared as a test scope dependency.New

Task #4664: Related to above: Test classes bring in org.apache.log4j.Logger but it is not declared as a test dependencyNew

Task #4665: Tests contain redundant code.New

Task #4666: - All types have the same serialVersionUID (10000000)New

Task #4667: - (Important!) No types implement equals or hashcodeNew

Task #4668: - No types implement toStringNew

Task #4669: - Regarding the style: A good addition to the types would be some builders, static factories and constructors as applicableNew

Task #4670: - Regarding the style: The types are fully mutable with no field validations or constraints. New

Task #4671: suggest updating the following versions:In Progress

Task #4672: mvn dependencies:analyse shows transitive dependencies:In Progress

Task #4673: Pom has warnings:New


#1 Updated by Robert Waltz almost 10 years ago

  • Milestone changed from CCI-1.3 to None

#2 Updated by Dave Vieglais over 9 years ago

  • Target version set to Release Backlog
  • Due date set to 2014-10-01
  • Start date set to 2014-10-01

#3 Updated by Rob Nahf over 9 years ago

  • Target version changed from Release Backlog to CLJ-2.0.0
  • Project changed from Infrastructure to Java Client
  • Category changed from d1_common_java to d1_common_java

#4 Updated by Rob Nahf over 7 years ago

  • % Done changed from 0 to 30
  • Status changed from New to In Progress

#5 Updated by Dave Vieglais over 6 years ago

  • % Done changed from 30 to 100
  • Status changed from In Progress to Closed

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 14.8 MB)