Project

General

Profile

Bug #3699

CN.updateReplicaMetadata preventing valid update

Added by Skye Roseboom about 8 years ago. Updated about 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ben Leinfelder
Category:
Metacat
Target version:
-
Start date:
Due date:
% Done:

100%

Milestone:
None
Product Version:
*
Story Points:
Sprint:

Description

Discovered while testing replica auditing. The business logic in CNodeService.updateReplicationMetadata prevents an update to the verification date when the replica status is 'completed'. It may be that the status change business logic need only be invoked when the status is changing. Prevents auditing from updating valid replicas with a new verification date.

Redmine3699.patch Magnifier (1.24 KB) Skye Roseboom, 2013-04-03 20:22

History

#1 Updated by Skye Roseboom about 8 years ago

  • Status changed from New to In Progress
  • Assignee changed from Chris Jones to Skye Roseboom

Creating a patch update for this issue.

#2 Updated by Skye Roseboom about 8 years ago

patch file attached.

Only throws InvalidRequest regarding invalid status change of a 'completed' replica if the replica status is changing.

#3 Updated by Skye Roseboom about 8 years ago

  • Assignee changed from Skye Roseboom to Matthew Jones

Hi Matt - could you sanity check this patch and commit to metacat?

It is a minor one line change - such that the replica status change validation need only be performed when the status is changing. (Comparing incoming replica's status to the existing replica status)

thanks!

#4 Updated by Ben Leinfelder about 8 years ago

  • Assignee changed from Matthew Jones to Ben Leinfelder

I will incorporate this so it is included in v2.0.6

#5 Updated by Ben Leinfelder about 8 years ago

  • Status changed from In Progress to Closed

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 14.8 MB)