Task #2349: Default algorithm "SHA-1" is not allowed. - Infrastructure - DataONE Tasks

Task #2349

Story #2045: Get the DataONE CLI ready for public release

Default algorithm "SHA-1" is not allowed.

Added by Andrew Pippin about 12 years ago. Updated about 12 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Andrew Pippin

Category:

d1_client_cli

Target version:

Sprint-2012.11-Block.2.2

Start date:

2012-02-17

Due date:

% Done:

100%

Estimated time:

1.00 h

Milestone:

CCI-1.0.0

Product Version:

Story Points:

Sprint:

Description

When invoking the CLI, the system default algorithm is "SHA-1", which is no longer allowed.

History

#1 Updated by Andrew Pippin about 12 years ago

According to Roger Dahl:

This is a bug due to a change of the DataONE default hashing algorithm in d1_common.const from "SHA1" to "SHA-1". We used to allow both on the Python side, but changed that, as I mentioned. However, only "SHA1" is valid when creating a hashing object by name in Python.

The fix is to use a map between DataONE names for the algorithms and the Python names. I've already implemented that, but don't use it in the CLI.

#2 Updated by Andrew Pippin about 12 years ago

% Done changed from 0 to 100

Fixed by Roger (r7053, r7054, r7055). There is a new utility routine (d1_common.util.get_checksum_calculator_by_dataone_designator) to map the DataONE algorithm name to the Python algorithm name (i.e. "SHA-1" to "sha1").