Project

General

Profile

Story #1551

Refactor d1_common_java tests for MultipartRequestHandler

Added by Robert Waltz over 10 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
d1_common_java
Target version:
Start date:
2011-05-11
Due date:
% Done:

100%

Story Points:
Sprint:

Description

I think the d1_common_java tests for MultipartRequestHandler can be replaced. We would need to add new tests along with some modification to the MultipartRequestHandler (the class being tested) so that we can inject a HttpClient interface mock implementation that mimics the echo service on dev-testing rather than, as we are currently doing, testing the apache default HttpClient implementation that is a dependency of the class.

Essentially, we should have a dependency on the interface,HttpClient, rather than on the implementation (DefaultHttpClient) in the MultipartRequestHandler, and we need getter/setter methods for that interface dependency so as to replace it for unit testing.

We should also move the current tests into integration testing.


Subtasks

Task #1552: Copy TestSimpleMultipartEntity from d1_common_java to d1_integrationNewRob Nahf

Task #1553: Modify MultipartRequestHandler to include HttpClient interfaceClosedRob Nahf

Task #1554: Create MockHttpClient for testing in d1_common_javaNewRob Nahf

Task #1555: Modify TestSimpleMultipartEntity for use with MockHttpClientNewRob Nahf

Task #1559: Refactor d1_libclient_java echo tests NewRob Nahf


Related issues

Related to Java Client - Story #2253: refactor libclient_java communication to enable unit testing via mock client Rejected 2012-01-23 2015-01-06

History

#1 Updated by Dave Vieglais over 10 years ago

  • Position set to 11
  • Target version changed from Sprint-2011.20-Block.3 to Sprint-2011.21-Block.3

#2 Updated by Rob Nahf over 10 years ago

just saw this one... need to get priority

#3 Updated by Dave Vieglais over 10 years ago

  • Position deleted (16)
  • Position set to 4
  • Target version changed from Sprint-2011.21-Block.3 to Sprint-2011.22-Block.3

#4 Updated by Dave Vieglais over 10 years ago

  • Position set to 17
  • Position deleted (5)
  • Target version changed from Sprint-2011.22-Block.3 to Sprint-2011.23-Block.3

#5 Updated by Rob Nahf over 10 years ago

  • Target version deleted (Sprint-2011.23-Block.3)
  • Position set to 172
  • Position deleted (20)

#6 Updated by Dave Vieglais over 10 years ago

  • Position set to 36
  • Position deleted (198)

#7 Updated by Dave Vieglais over 10 years ago

  • Position deleted (48)
  • Position set to 36

#8 Updated by Rob Nahf over 9 years ago

  • Milestone changed from 2011-Block-3 to CCI-1.1

#9 Updated by Rob Nahf about 9 years ago

  • Due date set to 2012-10-27
  • Target version set to Sprint-2012.41-Block.6.1
  • Start date set to 2012-10-07
  • Milestone changed from CCI-1.1 to None

#10 Updated by Rob Nahf about 9 years ago

  • Status changed from New to In Progress

#11 Updated by Rob Nahf about 9 years ago

  • Due date changed from 2012-10-27 to 2012-11-10
  • Target version changed from Sprint-2012.41-Block.6.1 to Sprint-2012.44-Block.6.2

#12 Updated by Rob Nahf almost 9 years ago

  • Due date changed from 2012-11-10 to 2013-02-02
  • Target version changed from Sprint-2012.44-Block.6.2 to 2013.4-Block.1.2

#13 Updated by Rob Nahf almost 9 years ago

  • Target version changed from 2013.4-Block.1.2 to 2013.14-Block.2.3
  • Due date changed from 2013-02-02 to 2013-04-13

#14 Updated by Rob Nahf over 8 years ago

  • Target version changed from 2013.14-Block.2.3 to 2013.20-Block.3.2
  • Due date changed from 2013-04-13 to 2013-05-25

#15 Updated by Rob Nahf over 8 years ago

  • Target version changed from 2013.20-Block.3.2 to 2013.22-Block.3.3
  • Due date changed from 2013-05-25 to 2013-06-08

#16 Updated by Rob Nahf over 8 years ago

  • Due date changed from 2013-06-08 to 2013-08-10
  • Target version changed from 2013.22-Block.3.3 to 2013.30-Block.4.3

#17 Updated by Dave Vieglais over 8 years ago

  • Due date deleted (2013-08-10)
  • Start date deleted (2011-05-11)
  • Target version deleted (2013.30-Block.4.3)

#18 Updated by Robert Waltz over 8 years ago

  • Parent task set to #3750

#19 Updated by Robert Waltz about 7 years ago

  • Parent task deleted (#3750)

#20 Updated by Robert Waltz about 7 years ago

  • Tracker changed from Task to Story
  • Start date deleted (2011-05-11)

#21 Updated by Robert Waltz about 7 years ago

  • Start date set to 2014-12-01
  • Target version set to CCI-2.0.0
  • Due date set to 2014-12-01

#22 Updated by Dave Vieglais almost 7 years ago

  • Due date changed from 2014-12-01 to 2015-01-06

#23 Updated by Rob Nahf almost 7 years ago

  • Target version changed from CCI-2.0.0 to CLJ-2.0.0
  • % Done changed from 20 to 30
  • Category changed from d1_common_java to d1_common_java
  • Project changed from Infrastructure to Java Client

#24 Updated by Matthew Jones almost 7 years ago

This would be a great change to allow unit tests via the Mock interface, so I support it. However, we also need to be sure to test the actual connections as implemented in the apache default HttpClient implementation in an integration test. I think we should not assume that just because a Mock test passes, a real network test will also pass. Let's keep the integration tests.

#25 Updated by Rob Nahf over 6 years ago

delete this deprecated class and close this ticket.

#26 Updated by Dave Vieglais almost 4 years ago

  • % Done changed from 30 to 100
  • Status changed from In Progress to Closed

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 14.8 MB)