Project

General

Profile

Task #1507

Story #1275: Fix metacat bugs

refactor MetacatRestClient.sendData to match current dataone spec (mime multipart)

Added by Rob Nahf almost 11 years ago. Updated over 10 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
Due date:
% Done:

20%

Milestone:
Product Version:
*
Story Points:
Sprint:

Description

currently sending (posting) data as name value pairs (somehow), but now needs to be mime-multipart.
This should fix errors in MetacatRestClientTest integration tests.

History

#1 Updated by Rob Nahf almost 11 years ago

  • Subject changed from update MetacatRestClient.sendData to match current dataone spec (mime multipart) to update MetacatRestClient.sendData to match current dataone spec (mime multipart)

This class is nearly redundant to the dataone client, especially since metacat imports the d1_libclient jar. Differences exist, though are mainly in the interface (method names and exceptions thrown). Best route for refactoring is to use the org.dataone.client.RestClient (which is dataone-unaware) and org.dataone.mimemultipart.SimpleMultipartEntity - similar to how the dataone client was built.

Else, if the MetacatRest interface isn't needed, just use the dataone.client.MNode class.

Sort of depends on fix to SimpleMultipartEntity.addFilePart() signature. (unless we don't mind touching and retesting at a later date)

#2 Updated by Rob Nahf almost 11 years ago

  • Subject changed from update MetacatRestClient.sendData to match current dataone spec (mime multipart) to refactor MetacatRestClient.sendData to match current dataone spec (mime multipart)

#3 Updated by Rob Nahf almost 11 years ago

if MetacatRest is still required, we should probably reconcile the dataone interface with it...

#4 Updated by Rob Nahf over 10 years ago

  • translation missing: en.field_remaining_hours changed from 3.0 to 1.0
  • Status changed from New to In Progress
  • % Done changed from 0 to 20

the MetacatRestClient is outdated, and will be retired. No refactor necessary, although we need to comment out the tests.

#5 Updated by Rob Nahf over 10 years ago

  • Status changed from In Progress to Rejected
  • translation missing: en.field_remaining_hours changed from 1.0 to 0.0

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 14.8 MB)